-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for graceful eviction controller #5543
base: master
Are you sure you want to change the base?
Added tests for graceful eviction controller #5543
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f615e61
to
6edcb2a
Compare
Hi @zhzhuang-zju , the tests are working fine locally. What can be the problem in setupManager test. |
From the CI error messages, the reason for the test failure is not clear. I will try to analyze the cause of the failure from the code perspective. |
The setup manager tests fails for each controller everytime on the CI, i had removed that tests from some of my last PR's. I haven't been able to find the root cause of CI failures for them. |
Cannot determine the root cause of the test failure. You can try adding output logs and use your private repository's CI to identify the issue. |
I'm not able to debug it, i think we should proceed without it. |
2ff858e
to
80b715b
Compare
Signed-off-by: Anuj Agrawal <[email protected]> Added tests for gracefuleviction controller Signed-off-by: Anuj Agrawal <[email protected]> Added tests for gracefuleviction contoller Signed-off-by: Anuj Agrawal <[email protected]> Added tests for gracefuleviction controller Signed-off-by: Anuj Agrawal <[email protected]> Added tests for gracefuleviction controller Signed-off-by: Anuj Agrawal <[email protected]>
80b715b
to
547a6a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5543 +/- ##
==========================================
+ Coverage 34.14% 34.27% +0.12%
==========================================
Files 643 643
Lines 44509 44503 -6
==========================================
+ Hits 15197 15252 +55
+ Misses 28156 28090 -66
- Partials 1156 1161 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description:
This PR adds comprehensive unit tests for the ResourceBinding (RB) and ClusterResourceBinding (CRB) graceful eviction controllers.
Additions:
Additionally, a new test case has been added to the
Test_nextRetry
function inevictiontask_test.go
to increase coverage.Test Coverage:
Overall graceful eviction controller : 35.90% to 76.7%
What type of PR is this?
/kind failing-test
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: