Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/webhook: refactor Multi-Cluster Service test #5539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we refactor the multi-cluster service object names and check on number of patches after the mutation happens.

Motivation and Context

Motivated by @XiShanYongYe-Chang's comment #5494 (comment).

What type of PR is this?

/kind cleanup

Which issue(s) this PR fixes:
Follow-up on #5517.

Does this PR introduce a user-facing change?:

NONE

In this commit, we refactor the multi-cluster service obj names
and check on number of patches after the mutation happens.

Signed-off-by: Mohamed Awnallah <[email protected]>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 13, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chaunceyjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.04%. Comparing base (bf83dfe) to head (47290cb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5539   +/-   ##
=======================================
  Coverage   34.03%   34.04%           
=======================================
  Files         643      643           
  Lines       44509    44509           
=======================================
+ Hits        15150    15151    +1     
- Misses      28205    28206    +1     
+ Partials     1154     1152    -2     
Flag Coverage Δ
unittests 34.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants