-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: introducing a scheduling strategy to customize cluster propagation priorities #5512
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5512 +/- ##
===========================================
+ Coverage 31.70% 42.42% +10.71%
===========================================
Files 643 656 +13
Lines 44445 55884 +11439
===========================================
+ Hits 14090 23707 +9617
- Misses 29325 30658 +1333
- Partials 1030 1519 +489
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3d020fd
to
add8e03
Compare
+ // ... | ||
+ // +kubebuilder:validation:Enum=sequential | ||
+ // +optional | ||
+ ClusterAffinitiesOrder ClusterAffinitiesOrder `json:"clusterAffinitiesOrder,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could explicit priority declaration for clusters be implemented, considering the following points:
- We can define the priority of clusters as an inherent attribute of the clusters themselves. Various scheduling methods would then act merely as consumers of this data, avoiding binding them directly to any specific scheduling approach.
- The current Solution 2 has coupling between different clusterAffinities, which requires determining the priority of clusters based on the order in which clusters appear within the clusterAffinity. Additionally, it does not allow for distinguishing the priority relationship between clusters that appear for the first time within the same clusterAffinity.
…agation priorities Signed-off-by: chaosi-zju <[email protected]>
add8e03
to
6921114
Compare
/retest |
What type of PR is this?
/kind feature
/kind design
What this PR does / why we need it:
This proposal introduces a new user scenario for scheduling, where users have preferences for clusters with
varying priorities and want replicas assigned to their preferred clusters.
To support this scenario, we propose two alternative solutions: one is adding
aggregatePreference
to the existingWeighted
replica scheduling strategy, and the other is enhancing the capability of multiple scheduling groups.Ultimately, we compare these two options and decide on the best implementation to provide a scheduling strategy
that allows users to customize cluster propagation priorities.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: