Open
Conversation
Owner
|
Thanks :) Can explain again what exactly this PR does? Maybe with a screenshot. |
Author
|
Yup sure! Previously, when running jobs with GPUS attached to them, they won't show. I believe this is due to slurm having a separate flag for GPUS After change: |
|
is here anything missing to get it merged? I would offer some help if requiered -- really looking forward to this feature! |
Author
|
@fzimmermann89 might be unresolved conflicts, I could relook at this after I sync my fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change, adds the
gresafter thetres-alloc. Wondering if we could potentially map them to a hashmap or sort so that its easier to work with in future?I can open up another Feature request and can look at it again when I have the time, just implemented this quick one for my cluster