Conversation
This commit adds wrapping behavior to the help line at the bottom. It measures the required lines based on the current frame buffer area and creates a matching layout. The commit required a dependency update of `ratatui` to `0.29.0` to gain access to the `Frame#area` method.
karimknaebel
left a comment
karimknaebel
left a comment
There was a problem hiding this comment.
Looks good overall. I think I would prefer lazygit's behavior of just truncating the help string and show an ellipsis:
| lazy_static = "1.4.0" | ||
| notify = "6.1.1" | ||
| ratatui = "0.27.0" | ||
| ratatui = "0.29.0" |
There was a problem hiding this comment.
is this necessary for some new API?
There was a problem hiding this comment.
It is necessary for the Frame#area function. But that function is just a name change. It's the same as the Frame#size function. I originally used another approach that required the version bump. I can revert the version change if you want. It is not necessary for the code change I did.
Is it possible to somehow show the full help string in that case? Like focusing the UI component and let it scroll? At least on my machine and the way my display is configured, my maximized terminal is too small to see the whole help string. The whole idea of the change was that even in these cases one can see the whole help message! |
2 participants
This commit adds wrapping behavior to the help line at the bottom.
It measures the required lines based on the current frame buffer
area and creates a matching layout.
The commit required a dependency update of
ratatuito0.29.0to gain access to the
Frame#areamethod.Fixes #35.