Don't sync declined events #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, this is good, but I think not necessarily always desired by everyone. Maybe adding a boolean to toggle this behavior in the header section would be helpful. |
|
@ineffyble, I love this PR. @hgabreu I do agree that some people may want declined events to still be synced. |
|
@ineffyble Can you test the changes on your system to make sure we're good? I'll test on mine. Once we're good, I'll merge! |
Ratithoglys
added a commit
to Ratithoglys/sync-multiple-google-calendars
that referenced
this pull request
Sep 20, 2023
Don't sync declined events From karbassi#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents syncing an event where you have declined the invitation. This is useful since declining an invitation does not automatically delete the event from your calendar.
This code could probably be improved with optional chaining, but this is the version I know works.