feat: #29 Implement frontend order recovery from coordinator API#41
feat: #29 Implement frontend order recovery from coordinator API#41BuddiBisong wants to merge 4 commits into
Conversation
|
Someone is attempting to deploy a commit to the karagoz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@BuddiBisong Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Thanks for the PR. I checked it against issue #29 and cannot merge it yet. Blocking issues:
Please move the history route before /orders/:id or otherwise make it reachable, then get the frontend tests and build green. After that I can re-review for #29 acceptance. |
af7fbf6 to
510fd3a
Compare
|
Thanks for the update. I re-ran the review after your latest commits. What now passes:
Remaining blocker before I can merge:
Please strip the trailing whitespace and push one more update. The functional blockers from the previous review look resolved. |
|
I have removed the trailing white Space in the specified files Pls merge |
|
Re-checked the latest head after the whitespace update. The frontend tests pass now, but the frontend build still fails, so I cannot merge. Passed:
Failing command:
Errors: Please restore the missing imports/usages in
|
|
Thanks for the update. I rechecked this under the karagozemin account. Passing checks:
The previous functional build blockers are fixed. I still cannot merge this exact branch because it includes unrelated documentation churn outside issue #29's scope, including edits to:
Most of those doc diffs are whitespace/formatting changes and are not needed for frontend order recovery. Please remove the unrelated docs/report file from this PR so the diff stays focused on:
After the scope cleanup, this looks ready to merge if the same checks stay green. |
|
Thanks for the cleanup commit. I rechecked the latest merge ref from the maintainer account. Passing checks: git diff --check master...pr-41-merge
pnpm --filter @oversync/sdk build
pnpm --filter @oversync/frontend test -- --run
pnpm --filter @oversync/frontend build
pnpm --filter @oversync/coordinator testResults: frontend tests pass (107), frontend build passes, coordinator tests pass (79). I still cannot merge this branch because the scope cleanup is not complete. The current diff still modifies/deletes unrelated documentation outside issue #29: Those docs should not be deleted by the frontend order recovery PR. Please restore/remove those doc changes from the branch so the diff is focused on the order recovery files, coordinator history route change, and SDK type addition only. Once the docs deletion is gone, this looks ready to merge if the same checks stay green. |
68257a7 to
fc15377
Compare
|
Done |
|
Pls Merge |
|
Thanks for the cleanup. I rechecked the merge ref from the maintainer account and the functional checks are green: git diff --check master...pr-41-merge
pnpm --filter @oversync/sdk build
pnpm --filter @oversync/frontend test -- --run
pnpm --filter @oversync/frontend build
pnpm --filter @oversync/coordinator testResults: frontend tests pass (108), frontend build passes, coordinator tests pass (85), and the unrelated docs deletion is gone. I tried to merge, but GitHub now reports the branch as |
|
But its showing no conflict with base branch |
|
All checks have passed on the locally and on my forked repo pls merge |
|
Thanks for the PR! The code builds fine locally ✅, but GitHub reports merge conflicts with the base branch. Could you rebase onto the latest |
Closes #29
Fixes Wave 6 #29: Pending/refundable swaps now survive page reloads