Frontend builds#40
Conversation
- Add SorobanOrderStatus and SorobanOrderData types to packages/sdk/src/types/index.ts - Update SorobanHTLCClient.getOrder() to return Promise<SorobanOrderData | null> - Export parseSorobanOrder() pure helper for normalising raw scValToNative payloads - Handle Uint8Array/Buffer/string hex for byte fields, bigint coercion for numerics - Treat empty preimage bytes (Funded state) as empty string - Add 14 tests covering funded, claimed, refunded, null, malformed, and edge cases
|
Someone is attempting to deploy a commit to the karagoz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@nikkybel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Thanks for the PR. I tested the current head against current Commands run: pnpm install --frozen-lockfile
pnpm --filter coordinator test
pnpm --filter coordinator build
pnpm --filter resolver test
pnpm --filter resolver build
pnpm --filter relayer test
pnpm --filter relayer build
pnpm --filter frontend exec vitest run
pnpm --filter frontend buildFailure: Please remove or use the unused |
|
Alright |
|
@karagozemin I have implemented the necessary changes, can you be please check if it's ok ? |
|
Re-checked the latest head as requested. The previous frontend build blocker is still present, so I still cannot merge this. Commands that passed:
Still failing:
Error:
Please remove or use the unused |
|
Hey @karagozemin I have implemented the necessary changes, can you be please check if it's ok ? |
|
Thanks for the update. I rechecked the merge ref under the karagozemin account. Still blocked: The failure happens before the new config tests can run, so I could not continue through the coordinator/relayer/resolver/frontend build chain. Please fix the |
Summary
Adds strict environment validation across the coordinator, resolver, relayer, and frontend to ensure deployment-critical configuration errors are detected early and fail fast during startup or build time.
Motivation
Several packages relied on direct access to environment variables without centralized validation. This increased the risk of runtime failures and accidental misconfigurations during deployments.
Since mainnet support remains disabled pending audit and production approval, this change also introduces safeguards that prevent accidental mainnet activation through configuration mistakes.
Changes
Coordinator
Resolver
Relayer
Added validation for:
Prevents startup when required values are missing or malformed.
Frontend
VITE_MAINNET_ENABLED=true.Documentation
Updated environment configuration documentation.
Added and clarified required variables in:
env.exampledocs/DEPLOYMENT.mdTesting
Acceptance Criteria
Affected Areas
coordinator/src/config.tsresolver/src/config.tsrelayer/src/index.tsrelayer/src/phase6-bridge-service.tsfrontend/src/config/networks.tsenv.exampledocs/DEPLOYMENT.mdImpact
This change improves deployment safety, reduces runtime configuration errors, and makes CI/CD failures easier to diagnose by surfacing configuration issues before services begin processing requests.
close #33