Skip to content

feat: Add env example drift check for app and service packages#217

Open
CollinsKRO wants to merge 2 commits into
karagozemin:masterfrom
CollinsKRO:env
Open

feat: Add env example drift check for app and service packages#217
CollinsKRO wants to merge 2 commits into
karagozemin:masterfrom
CollinsKRO:env

Conversation

@CollinsKRO

@CollinsKRO CollinsKRO commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

@CollinsKRO is attempting to deploy a commit to the karagoz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@karagozemin

Copy link
Copy Markdown
Owner

Thanks for the PR. I rechecked the merge ref from the maintainer account, but the new drift check is currently failing.

Commands run:

git diff --check master...pr-217-merge
node scripts/check-env-docs.mjs

git diff --check is clean, but the new script exits non-zero:

✗ 4 env var(s) missing from env.example
APP_PRIVATE_KEY
SERVICE_BEARER_TOKEN
HTLC_PREIMAGE
VITE_FRONTEND_URL

Please either document those vars in env.example or add narrowly justified allowlist entries if they are test-only/internal. Also please keep the scope focused: this PR is for env example drift, but it currently changes resolver/src/commands/check.ts and overlaps the resolver preflight/check JSON work from #216/#219. If that resolver command change is not required for env drift, please remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants