Skip to content

docs: add investor-grade risk register with mitigations and evidence links#146

Open
CollinsKRO wants to merge 7 commits into
karagozemin:masterfrom
CollinsKRO:branch
Open

docs: add investor-grade risk register with mitigations and evidence links#146
CollinsKRO wants to merge 7 commits into
karagozemin:masterfrom
CollinsKRO:branch

Conversation

@CollinsKRO

Copy link
Copy Markdown
Contributor

closes #94

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

@CollinsKRO is attempting to deploy a commit to the karagoz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 29, 2026

Copy link
Copy Markdown

@CollinsKRO Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@karagozemin

Copy link
Copy Markdown
Owner

Thanks for the risk register. The content is aligned with issue #94: it links from README/data room, is explicit about unaudited status, and includes concrete owner/action fields across the register.

I cannot merge yet because whitespace validation fails:

git diff --check origin/master...HEAD

reports trailing whitespace in docs/RISK_REGISTER.md:

  • line 3
  • line 4

Please remove those trailing spaces. After that, I can re-run git diff --check and node scripts/check-evidence-links.mjs and merge if clean.

@karagozemin

karagozemin commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Thanks for the update. I rechecked the merge ref as karagozemin.

Good news: the previous whitespace blocker is fixed now:

  • git diff --check origin/master...HEAD passes

I still cannot merge yet because two evidence links in docs/RISK_REGISTER.md point to files that do not exist on this branch:

  • ../coordinator/src/services/orderbook.ts on the R-005 current evidence row
  • ../coordinator/src/config/rpc.ts on the R-007 current evidence row

The actual coordinator files appear to be coordinator/src/services/order-service.ts, coordinator/src/config.ts, and coordinator/src/ethereum-rpc-url.ts. Please update those evidence links to real repo paths, then I can re-run the link check and merge if clean.

@CollinsKRO

Copy link
Copy Markdown
Contributor Author

I've bee trying to resolve this issue but the toggle bar isn't clicking. is there anything I can do about it?

@CollinsKRO

Copy link
Copy Markdown
Contributor Author

pls review this

- Remove duplicate getMetrics method from orders-repo.ts
- Fix timelock ordering in coordinator tests (dstTimelock < srcTimelock)
- Add missing mock exports in App.test.tsx for getCurrentNetwork/getContractAddresses/getFaucets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SCF high] Create investor-grade risk register with mitigations and evidence links

2 participants