Conversation
…hitecture Establish a clean two-phase architecture for request parameters: **Intent** (CLI → HTTP → Zod → handler): all optional, pure pass-through, zero defaults. Zod validates format only. **Resolved** (ProviderRequest → Provider adapter): fully determined. - ProviderRequest.cwd: string (non-optional, resolved from input.cwd ?? ctx.projectRoot) - ProviderRequest.effort: EffortLevel (non-optional, resolveEffort() called once in service) - Provider adapters translate only, never default Key changes: - ExecInput/ResumeInput/ForkInput/CoralInput → LaunchIntentBase + discriminated variants - coralDispatch() simplified to thin pre-processor delegating to start/resume - resume() accepts optional agent for instruction injection (replaces coralDispatch's manual resolution) - resolveEffort() removed from claude-executor.ts, moved to service layer - process.cwd() removed from all provider request paths - Codex effort mapping: Coral 'max' → Codex 'xhigh' - toProviderRequest() uses resolveEffort() for persisted record reconstruction Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests that deliberately trigger errors (KB init failure, probe unavailable) were printing ERROR lines to stderr, making clean test runs look like they had failures. Spy on process.stderr.write during those tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Ensures every EffortLevel maps to a Codex-accepted value (low/medium/ high/xhigh) and never leaks Coral-only values like 'max' to the RPC. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveEffort(),cwd,bypassPermissionsresolved hereProviderRequest.cwd: string,effort: EffortLevel(non-optional) — fully resolved contractExecInput/ResumeInput/ForkInput/CoralInput→LaunchIntentBase+ discriminated variantscoralDispatch()simplified to thin pre-processor delegating tostart()/resume()resume()accepts optionalagentfor instruction injectionmax→ Codexxhighprocess.cwd()from provider request paths,resolveEffort()from provider adaptersTest plan
npm run build:releasecleannpm test— 1549 tests pass, 0 failures, 0 errorsgrep -r 'process.cwd()' src/providers/ --include='*.ts' | grep -v __tests__— only infrastructure exceptionsgrep -r 'resolveEffort' src/providers/— 0 matches🤖 Generated with Claude Code