Add uki-serve command to pxe boot uki files #276

Itxaka · 2025-05-14T14:04:58Z

codecov · 2025-05-14T14:14:32Z

Codecov Report

Attention: Patch coverage is 0.42373% with 235 lines in your changes missing coverage. Please review.

Project coverage is 29.21%. Comparing base (4fd7151) to head (e1bed87).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/utils/pxeUki.go	0.00%	217 Missing ⚠️
internal/cmd/pxeUki.go	0.00%	18 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   31.13%   29.21%   -1.93%     
==========================================
  Files          22       24       +2     
  Lines        3533     3769     +236     
==========================================
+ Hits         1100     1101       +1     
- Misses       2254     2489     +235     
  Partials      179      179

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Itxaka <[email protected]>

Copilot

Pull Request Overview

This PR adds a new uki-pxe command to serve UKI boot artifacts over PXE/DHCP/TFTP/HTTP, embeds an EFI key enroller in constants, and registers the CLI entry.

Introduce ServeUkiPXE in pkg/utils/pxeUki.go to handle DHCP, PXE, TFTP, and HTTP serving for UKI.
Embed efi-key-enroller.efi as EfiKeyEnroller in pkg/constants/constants.go.
Add uki-pxe CLI command (internal/cmd/pxeUki.go) and register it in the app (internal/cmd/app.go).

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 9 comments.

File	Description
pkg/utils/pxeUki.go	Implement ServeUkiPXE and related protocol handlers
pkg/constants/constants.go	Embed EFI key enroller binary as `EfiKeyEnroller`
internal/cmd/pxeUki.go	Define `uki-pxe` CLI command with flags and action
internal/cmd/app.go	Register the `uki-pxe` command in the main CLI application

Files not reviewed (2)

Dockerfile: Language not supported
renovate.json: Language not supported

Comments suppressed due to low confidence (1)

pkg/utils/pxeUki.go:21

Add unit or integration tests for ServeUkiPXE, covering each protocol handler (DHCP, PXE, TFTP, HTTP).

func ServeUkiPXE(keydir, isoFile string, log types.KairosLogger) error {

pkg/utils/pxeUki.go

internal/cmd/pxeUki.go

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

This PR adds the uki-serve command to support serving PXE boot files for UKI images. Key changes include:

Adding a new utility package (pkg/utils/pxeUki.go) that implements PXE, DHCP, TFTP, and HTTP servers for booting.
Including a new embedded constant (EfiKeyEnroller) in pkg/constants/constants.go.
Introducing a new CLI command (internal/cmd/pxeUki.go) and updating the application command registry (internal/cmd/app.go).

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.

File	Description
pkg/utils/pxeUki.go	New implementation of server routines for PXE boot UKI files.
pkg/constants/constants.go	Adds the EfiKeyEnroller constant for EFI key enroller.
internal/cmd/pxeUki.go	New CLI command for starting the PXE boot server for UKI.
internal/cmd/app.go	Registers the new uki-pxe command with the application.

Files not reviewed (2)

Dockerfile: Language not supported
renovate.json: Language not supported

pkg/utils/pxeUki.go

Co-authored-by: Copilot <[email protected]>

Signed-off-by: Itxaka <[email protected]>

Copilot

Pull Request Overview

This PR introduces a new uki-pxe command and associated utilities to serve PXE (DHCP/PXE/TFTP) and HTTP endpoints for UKI boot workflows, including embedding an EFI key enroller.

Add ServeUkiPXE utility to run DHCP, PXE, TFTP, and HTTP servers for UKI boot.
Embed the EFI key enroller binary and expose it via TFTP/HTTP.
Register the new uki-pxe CLI command and wire it into the application.

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.

File	Description
pkg/utils/pxeUki.go	Implement `ServeUkiPXE` with `serveDHCP`, `servePXE`, `serveTFTP`, and `serveHTTP`.
pkg/constants/constants.go	Embed `efi-key-enroller.efi` as `EfiKeyEnroller`.
internal/cmd/pxeUki.go	Define `UkiPXECmd` CLI command for serving PXE UKI files.
internal/cmd/app.go	Register `UkiPXECmd` in the command list.

Files not reviewed (2)

Dockerfile: Language not supported
renovate.json: Language not supported

Comments suppressed due to low confidence (2)

pkg/utils/pxeUki.go:1

[nitpick] The file name pxeUki.go uses camelCase. Go conventions recommend lowercase with underscores (e.g., pxe_uki.go) to match package file naming style.

package utils

pkg/utils/pxeUki.go:23

This new ServeUkiPXE function and its sub-components (DHCP, PXE, TFTP, HTTP servers) lack accompanying unit or integration tests. Adding tests will help validate its behavior under various network scenarios.

func ServeUkiPXE(keydir, isoFile string, log types.KairosLogger) error {

pkg/utils/pxeUki.go

Signed-off-by: Itxaka <[email protected]>

internal/cmd/build-uki.go

pkg/constants/constants.go

pkg/utils/pxeUki.go

Remove check for dhcp in the PXE server Signed-off-by: Itxaka <[email protected]>

Signed-off-by: Itxaka <[email protected]>

pkg/constants/constants.go

mudler · 2025-05-23T07:33:37Z

pkg/utils/pxeUki.go

+	})
+
+	http.Handle("/", handler)
+	listenAddr := os.Getenv("HTTP_LISTEN_ADDR")


maybe better to have this as a cmd flag? wdyt?

Umm this was added by copilot but it's wrong, http server is harcoded to run in there I think as the whole thing doesn't deal with different http ports at all. So I think this need to be dropped

mudler

just small nit, didn't tested but changes looks good

Co-authored-by: Ettore Di Giacinto <[email protected]>

Signed-off-by: Itxaka <[email protected]>

Add uki-serve command to pxe boot uki files

b6d62ba

Signed-off-by: Itxaka <[email protected]>

Itxaka force-pushed the uki_pxe branch from 8cf295d to b6d62ba Compare May 22, 2025 07:13

Itxaka changed the title ~~Whatever~~ Add uki-serve command to pxe boot uki files May 22, 2025

Itxaka requested a review from a team May 22, 2025 07:13

Merge branch 'main' into uki_pxe

0b4c637

Itxaka marked this pull request as ready for review May 22, 2025 07:15

Copilot AI review requested due to automatic review settings May 22, 2025 07:15

Copilot AI reviewed May 22, 2025

View reviewed changes

Apply suggestions from code review

6d495df

Co-authored-by: Copilot <[email protected]>

Itxaka requested a review from Copilot May 22, 2025 07:40

Copilot AI reviewed May 22, 2025

View reviewed changes

pkg/utils/pxeUki.go Outdated Show resolved Hide resolved

pkg/utils/pxeUki.go Outdated Show resolved Hide resolved

Itxaka and others added 2 commits May 22, 2025 09:41

Apply suggestions from code review

3db28fb

Co-authored-by: Copilot <[email protected]>

Fix copilot fixes lol

157b2c5

Signed-off-by: Itxaka <[email protected]>

Itxaka requested a review from Copilot May 22, 2025 07:44

Copilot AI reviewed May 22, 2025

View reviewed changes

pkg/utils/pxeUki.go Outdated Show resolved Hide resolved

pkg/utils/pxeUki.go Show resolved Hide resolved

pkg/utils/pxeUki.go Outdated Show resolved Hide resolved

pkg/utils/pxeUki.go Outdated Show resolved Hide resolved

Fix log issue

563e69f

Signed-off-by: Itxaka <[email protected]>

jimmykarily reviewed May 22, 2025

View reviewed changes

internal/cmd/build-uki.go Outdated Show resolved Hide resolved

pkg/constants/constants.go Outdated Show resolved Hide resolved

pkg/utils/pxeUki.go Outdated Show resolved Hide resolved

Fix

02f2cfa

Remove check for dhcp in the PXE server Signed-off-by: Itxaka <[email protected]>

Itxaka force-pushed the uki_pxe branch from 7584009 to 02f2cfa Compare May 22, 2025 11:49

Itxaka added 2 commits May 23, 2025 09:27

Merge branch 'main' into uki_pxe

c04fb7b

Remove uneeded comment

cbb2798

Signed-off-by: Itxaka <[email protected]>

mudler reviewed May 23, 2025

View reviewed changes

pkg/constants/constants.go Outdated Show resolved Hide resolved

mudler reviewed May 23, 2025

View reviewed changes

mudler approved these changes May 23, 2025

View reviewed changes

Itxaka and others added 2 commits May 23, 2025 11:08

Update pkg/constants/constants.go

69fe46c

Co-authored-by: Ettore Di Giacinto <[email protected]>

Drop http port config

e1bed87

Signed-off-by: Itxaka <[email protected]>

Itxaka enabled auto-merge (squash) May 23, 2025 09:48

Itxaka merged commit 1f2c4fb into main May 23, 2025
13 of 16 checks passed

Itxaka deleted the uki_pxe branch May 23, 2025 10:34

Add uki-serve command to pxe boot uki files #276

Add uki-serve command to pxe boot uki files #276

Uh oh!

Conversation

Itxaka commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mudler May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Itxaka May 23, 2025

Choose a reason for hiding this comment

Uh oh!

mudler left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Itxaka commented May 14, 2025 •

edited

Loading

codecov bot commented May 14, 2025 •

edited

Loading