-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC for experimental async support #369
Draft
kagkarlsson
wants to merge
4
commits into
master
Choose a base branch
from
async-experimental
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kagkarlsson
commented
Apr 14, 2023
db-scheduler/src/main/java/com/github/kagkarlsson/scheduler/Executor.java
Outdated
Show resolved
Hide resolved
For example, why is this happening:
Possibly unbounded loop for fetch of executions to run?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variant of #304 which adds async-support without breaking anything. A bit hacky implementation since it relies on special interfaces and
instanceof
checking.AsyncExecutePicked
is just a modified duplication ofExecutePicked
.Current problems:
We are not waiting for allCompletableFuture
before shutdown.ExecutorService
no longer handles this.ManualScheduler
used in tests breaks now that everything is async. It relied onexecuteAnyDue
running the same thread, i.e. blocking until execution is done. How to handle this now?ManualScheduler
is used to clients as well.Options/thoughts:
Task
to returnExecutionHandler
instead of implementing it. Might make it easier to add async-variants to existing builder-classesExecutionHandler
? What about an async-mode that usesCompletableFuture
under-the-hood for execution and completion, similar to now?