Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet-sdk): added support for finding accounts by publickey [on-hold] #2839

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(wallet-sdk): added support for finding accounts by publickey [on-hold] #2839

wants to merge 6 commits into from

Conversation

nillo
Copy link
Contributor

@nillo nillo commented Jan 28, 2025 •
edited
Loading

[X] added support for finding accounts by publickey
Screenshot 2025-01-28 at 20 04 33

Screenshot 2025-01-28 at 20 04 38
Screenshot 2025-01-28 at 20 04 44

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e6c3f62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rwa-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:04am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
kode-ui ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 10:04am
dev-wallet ⬜️ Skipped (Inspect) Jan 30, 2025 10:04am
explorer ⬜️ Skipped (Inspect) Jan 30, 2025 10:04am
marmalade-marketplace ⬜️ Skipped (Inspect) Jan 30, 2025 10:04am
proof-of-us ⬜️ Skipped (Inspect) Jan 30, 2025 10:04am
tools ⬜️ Skipped (Inspect) Jan 30, 2025 10:04am

@vercel vercel bot temporarily deployed to Preview – dev-wallet January 28, 2025 13:10 Inactive
@vercel vercel bot temporarily deployed to Preview – proof-of-us January 28, 2025 13:10 Inactive
@vercel vercel bot temporarily deployed to Preview – tools January 28, 2025 13:10 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer January 28, 2025 13:10 Inactive
@vercel vercel bot temporarily deployed to Preview – marmalade-marketplace January 28, 2025 13:10 Inactive
@vercel vercel bot temporarily deployed to Preview – marmalade-marketplace January 28, 2025 14:29 Inactive
@vercel vercel bot temporarily deployed to Preview – tools January 28, 2025 14:29 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer January 28, 2025 14:29 Inactive
@vercel vercel bot temporarily deployed to Preview – dev-wallet January 28, 2025 14:29 Inactive
@vercel vercel bot temporarily deployed to Preview – proof-of-us January 28, 2025 14:29 Inactive
@nillo
Merge branch 'main' into feat/wallet-sdk-accountbypublickey
313b255 
# Conflicts:
#	packages/libs/wallet-sdk/src/gql/gql.ts
#	packages/libs/wallet-sdk/src/gql/graphql.ts
#	packages/libs/wallet-sdk/src/sdk/interface.ts
#	packages/libs/wallet-sdk/src/sdk/walletSdk.ts
@vercel vercel bot temporarily deployed to Preview – dev-wallet January 28, 2025 19:03 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer January 28, 2025 19:03 Inactive
@vercel vercel bot temporarily deployed to Preview – tools January 28, 2025 19:03 Inactive
@vercel vercel bot temporarily deployed to Preview – marmalade-marketplace January 28, 2025 19:03 Inactive
@vercel vercel bot temporarily deployed to Preview – proof-of-us January 28, 2025 19:04 Inactive
@nillo nillo marked this pull request as ready for review January 28, 2025 19:04
@nillo nillo requested a review from barthuijgen January 28, 2025 19:04
@nillo nillo requested a review from alber70g January 28, 2025 19:10
alber70g
alber70g approved these changes Jan 29, 2025
View reviewed changes
alber70g
alber70g requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@alber70g alber70g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment regarding two graphql types. Should only be one, and have a sensible error when the accountsByPublicKey is used on the one that doesn't support it.

@vercel vercel bot temporarily deployed to Preview – explorer January 30, 2025 10:00 Inactive
@vercel vercel bot temporarily deployed to Preview – tools January 30, 2025 10:00 Inactive
@vercel vercel bot temporarily deployed to Preview – marmalade-marketplace January 30, 2025 10:00 Inactive
@vercel vercel bot temporarily deployed to Preview – dev-wallet January 30, 2025 10:00 Inactive
@vercel vercel bot temporarily deployed to Preview – proof-of-us January 30, 2025 10:00 Inactive
@nillo nillo changed the title feat(wallet-sdk): added support for finding accounts by publickey feat(wallet-sdk): added support for finding accounts by publickey [on-hold] Jan 30, 2025
@nillo
Copy link
Contributor Author

nillo commented Jan 30, 2025

On hold until hackachain provides testnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alber70g alber70g alber70g requested changes

@barthuijgen barthuijgen Awaiting requested review from barthuijgen

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nillo @alber70g