Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Kudo button in feed page #165

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Sandervanmaurik
Copy link
Contributor

What

Explain what changes inside the code, this can be as simple or complicated as you want as long as it's clear

Why

Explain why these things are changes. This explanation is for your colleagues and your future self.

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

  • Does the code actually solve the problem it was meant to solve?
  • Is the code covered by unit tests? Integration tests?
  • Does anything here need documentation? (Focus on why, not what.)
  • Does any of this code deal with privacy sensitive information or affects security? Ask an additional reviewer.
  • Is the code easy to understand and change in the future?
  • Is the same code or concept duplicated? Find a balance between DRYness and readability.
  • Does the code reasonably adhere to the Kabisa coding standards?
  • Be kind.

class LikeButton extends Component<LikeButtonProps, LikeButtonState> {
constructor(props: LikeButtonProps) {
class LikeSection extends Component<LikeSectionProps, LikeSectionState> {
constructor(props: LikeSectionProps) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

Copy link

codeclimate bot commented Jan 23, 2024

Code Climate has analyzed commit 7d02f95 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 1

The test coverage on the diff in this pull request is 50.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 18.6% (1.1% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant