Skip to content

AGILE-954: Change endpoints map value type. #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alex60217101990 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AGILE-954: Change endpoints map value type. #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions 0009/0009-ep-connected.avsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,23 @@
"doc":"Connected endpoints' IDs map to their application version names",
"type":{
"type":"map",
"values":"string"
"values":{
"type": "record",
"name": "EndpointMeta",
"doc":"Endpoint metadata.",
"fields":[
{
"name":"appVersion",
"type":"string",
"doc":"Identifier of the endpoint application"
Copy link
Copy Markdown
Contributor

@AndrewPasika AndrewPasika Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"doc":"Identifier of the endpoint application"
"doc":"Identifier of the endpoint application version"

},
{
"name":"tenantId",
"type":"string",
"doc":"Identifier of the endpoint tenant"
}
]
}
}
},
{
Expand All @@ -34,4 +50,4 @@
"doc":"Identifier of the service replica that generated the event"
}
]
}
}
20 changes: 18 additions & 2 deletions 0009/0009-ep-disconnected.avsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,23 @@
"doc":"Disconnected endpoints' IDs map to their application version names",
"type":{
"type":"map",
"values":"string"
"values":{
"type": "record",
"name": "EndpointMeta",
"doc":"Endpoint metadata.",
"fields":[
{
"name":"appVersion",
"type":"string",
"doc":"Identifier of the endpoint application"
},
{
"name":"tenantId",
"type":"string",
"doc":"Identifier of the endpoint tenant"
}
]
}
}
},
{
Expand All @@ -34,4 +50,4 @@
"doc":"Identifier of the service replica that generated the event"
}
]
}
}
168 changes: 100 additions & 68 deletions 0009/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,41 +54,57 @@ The NATS message payload is an Avro object with the following schema ([ep-connec

```json
{
"namespace":"org.kaaproject.ipc.event.gen.v1.endpoint.connectivity",
"name":"ConnectedEvent",
"type":"record",
"doc":"Endpoints connected event message",
"fields":[
{
"name":"correlationId",
"type":"string",
"doc":"Message ID primarily used to track message processing across services"
},
{
"name":"timestamp",
"type":"long",
"doc":"Message creation UNIX timestamp in milliseconds"
},
{
"name":"timeout",
"type":"long",
"default":0,
"doc":"Amount of milliseconds since the timestamp until the message expires. Value of 0 is reserved to indicate no expiration."
},
{
"name":"endpoints",
"doc":"Connected endpoints' IDs map to their application version names",
"type":{
"type":"map",
"values":"string"
"namespace":"org.kaaproject.ipc.event.gen.v1.endpoint.connectivity",
"name":"ConnectedEvent",
"type":"record",
"doc":"Endpoints connected event message",
"fields":[
{
"name":"correlationId",
"type":"string",
"doc":"Message ID primarily used to track message processing across services"
},
{
"name":"timestamp",
"type":"long",
"doc":"Message creation UNIX timestamp in milliseconds"
},
{
"name":"timeout",
"type":"long",
"default":0,
"doc":"Amount of milliseconds since the timestamp until the message expires. Value of 0 is reserved to indicate no expiration."
},
{
"name":"endpoints",
"doc":"Connected endpoints' IDs map to their application version names",
"type":{
"type":"map",
"values":{
"type":"record",
"name":"EndpointMeta",
"doc":"Endpoint metadata.",
"fields":[
{
"name":"appVersion",
"type":"string",
"doc":"Identifier of the endpoint application"
},
{
"name":"tenantId",
"type":"string",
"doc":"Identifier of the endpoint tenant"
}
]
}
},
{
"name":"originatorReplicaId",
"type":"string",
"doc":"Identifier of the service replica that generated the event"
}
]
}
},
{
"name":"originatorReplicaId",
"type":"string",
"doc":"Identifier of the service replica that generated the event"
}
]
}
```

Expand All @@ -107,41 +123,57 @@ The NATS message payload is an Avro object with the following schema ([ep-discon

```json
{
"namespace":"org.kaaproject.ipc.event.gen.v1.endpoint.connectivity",
"name":"DisconnectedEvent",
"type":"record",
"doc":"Endpoints disconnected event message",
"fields":[
{
"name":"correlationId",
"type":"string",
"doc":"Message ID primarily used to track message processing across services"
},
{
"name":"timestamp",
"type":"long",
"doc":"Message creation UNIX timestamp in milliseconds"
},
{
"name":"timeout",
"type":"long",
"default":0,
"doc":"Amount of milliseconds since the timestamp until the message expires. Value of 0 is reserved to indicate no expiration."
},
{
"name":"endpoints",
"doc":"Disconnected endpoints' IDs map to their application version names",
"type":{
"type":"map",
"values":"string"
"namespace":"org.kaaproject.ipc.event.gen.v1.endpoint.connectivity",
"name":"DisconnectedEvent",
"type":"record",
"doc":"Endpoints disconnected event message",
"fields":[
{
"name":"correlationId",
"type":"string",
"doc":"Message ID primarily used to track message processing across services"
},
{
"name":"timestamp",
"type":"long",
"doc":"Message creation UNIX timestamp in milliseconds"
},
{
"name":"timeout",
"type":"long",
"default":0,
"doc":"Amount of milliseconds since the timestamp until the message expires. Value of 0 is reserved to indicate no expiration."
},
{
"name":"endpoints",
"doc":"Disconnected endpoints' IDs map to their application version names",
"type":{
"type":"map",
"values":{
"type":"record",
"name":"EndpointMeta",
"doc":"Endpoint metadata.",
"fields":[
{
"name":"appVersion",
"type":"string",
"doc":"Identifier of the endpoint application"
},
{
"name":"tenantId",
"type":"string",
"doc":"Identifier of the endpoint tenant"
}
]
}
},
{
"name":"originatorReplicaId",
"type":"string",
"doc":"Identifier of the service replica that generated the event"
}
]
}
},
{
"name":"originatorReplicaId",
"type":"string",
"doc":"Identifier of the service replica that generated the event"
}
]
}
```

Expand Down