Skip to content
This repository was archived by the owner on Aug 22, 2022. It is now read-only.

[omada-controller] Provide useful defaults #1632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[omada-controller] Provide useful defaults #1632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions charts/stable/omada-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,48 @@ service:
ports:
http:
port: 8043
management:
Copy link
Contributor

@bjw-s bjw-s Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it really adds much value to run three separate Services for this. Could you please take a look at how the Unifi Controller chart (https://github.com/k8s-at-home/charts/blob/master/charts/stable/unifi/values.yaml#L47) handles this, and implement it in a similar way?

enabled: false
ports:
tcp29811:
Copy link
Contributor

@bjw-s bjw-s Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add descriptive names to these ports?

Copy link
Contributor

@legonigel legonigel Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, 29811, 29812, 29813 are all device upgrade/management ports.

enabled: true
port: 29811
protocol: TCP
primary: false
tcp29812:
enabled: true
port: 29812
protocol: TCP
primary: false
tcp29813:
enabled: true
port: 29813
protocol: TCP
primary: false
discovery:
enabled: false
ports:
udp29810:
enabled: true
port: 29810
protocol: UDP
primary: false

ingress:
# -- Enable and configure ingress settings for the chart under this key.
# @default -- See values.yaml
main:
enabled: false
# annotations:
# nginx.ingress.kubernetes.io/backend-protocol: HTTPS
# nginx.ingress.kubernetes.io/proxy-redirect-from: https://$http_host:8043/
# nginx.ingress.kubernetes.io/proxy-redirect-to: https://$http_host/
# nginx.ingress.kubernetes.io/configuration-snippet: |
# proxy_set_header Host $http_host:8043;
Comment on lines +61 to +66
Copy link
Contributor

@bjw-s bjw-s Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to keep our charts Ingress-agnostic.
Even though the annotations are commented out, it would be preferred if you would describe the required configuration in the README_CONFIG.md.gotmpl file.

I don't know the Omada controller well enough, but I'm also not sure all 4 of these are 100% required? I can imagine that it depends on how the rest of the Ingress (controller) is set up.


# -- Configure persistence settings for the chart under this key.
# @default -- See values.yaml
persistence:
data:
enabled: false
mountPath: /opt/tplink/EAPController/data
Copy link
Contributor

@bjw-s bjw-s Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍