add node-internal-dns/node-external-dns address pass-through support

[arnemileswinter]

Proposed Changes

Add support for setting NodeInternalDNS and NodeExternalDNS addresses via stub cloud provider

Types of Changes

enhancement

Verification

k3s server --node-external-dns node.example.com

now yields:

As you can see it correctly sets the ExternalDNS address.

Testing

Linked Issues

• Support for NodeExternalDNS #10848

User-Facing Change

Further Comments

[cwayne18]

/trivy

[github-actions]

[arnemileswinter]

Thank you for your guidance @brandond
admittedly the flannel lines were mere copypasta as you've spotted :)
(I implemented this feature with a CTRL+F on NodeExternalIP and adjusted all the places to support NodeExternalDNS.)

I have compiled the artifact and both external and internal dns entries are now populated:

kubectl get nodes -o yaml
apiVersion: v1
items:
- apiVersion: v1
  kind: Node
  metadata:
    annotations:
# leaving flannel lines out
      k3s.io/external-dns: node.example.com
      k3s.io/external-ip: 192.168.178.23
      k3s.io/hostname: thinkpad-t440p
      k3s.io/internal-dns: internal.example.com
      k3s.io/internal-ip: 192.168.178.23
      k3s.io/node-args: '["server","--docker","--node-external-dns","node.example.com","--node-internal-dns","internal.example.com"]'
# i am leaving these lines out
  status:
    addresses:
    - address: 192.168.178.23
      type: InternalIP
    - address: 192.168.178.23
      type: ExternalIP
    - address: internal.example.com
      type: InternalDNS
    - address: node.example.com
      type: ExternalDNS
    - address: thinkpad-t440p
      type: Hostname

[brandond]

It LGTM but you added some unnecessary fields to the AgentConfig. Once those comments are addressed i think we're set. Thanks!

[arnemileswinter]

hey @brandond i applied ur suggestions
(had to rebuild again and it takes a while on my PC, sorry for leaving you hanging)

I could also verify that settings multiple --external-node-dns flags works :)

[brandond]

last nit

[brandond]

we can merge this to master, but today is the last day before code freeze for the September releases.. so I'm scheduling it to wait until next month to hit the release branches.

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 43.94%. Comparing base (216c367) to head (3345d8d).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/agent/run.go	25.00%	2 Missing and 4 partials ⚠️
pkg/cloudprovider/instances.go	0.00%	4 Missing and 2 partials ⚠️
pkg/agent/config/config.go	50.00%	2 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (216c367) and HEAD (3345d8d). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (216c367)	HEAD (3345d8d)
e2etests	7	6

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10852      +/-   ##
==========================================
- Coverage   49.98%   43.94%   -6.04%     
==========================================
  Files         178      178              
  Lines       14777    14801      +24     
==========================================
- Hits         7386     6505     -881     
- Misses       6048     7091    +1043     
+ Partials     1343     1205     -138     

Flag	Coverage Δ
e2etests	36.45% <33.33%> (-9.73%)	⬇️
inttests	19.72% <25.00%> (-17.02%)	⬇️
unittests	13.55% <0.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.