Allow cancelling active reservations until they end#33
Merged
Conversation
Agent-Logs-Url: https://github.com/k0swe/station-reservation/sessions/9742a07d-b0d2-4ca2-ad75-3de6259cb76c Co-authored-by: xylo04 <389971+xylo04@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
xylo04
May 25, 2026 02:25
View session
|
Updates to Preview Branch (copilot/allow-cancel-in-progress-reservation) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reservations could only be cancelled before their start time, which blocked owners and club admins from cancelling a reservation once it was already underway. This change extends cancellation to any active reservation that has not yet ended, while preserving the existing restriction on ended reservations.
Backend
cancel_reservationRPC to allow cancellation while a reservation is in progress.starts_at <= now()toends_at <= now(), so ended reservations remain non-cancellable.Frontend
Coverage