Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress k0s binary using UPX #5470

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 23, 2025

Description

Make this configurable via Make variables.

This is a PoC based on #5468, to see if it is generally possible and to have something to tinker with. CI seems to be passing. The size reduction is about 25% for the linux-amd64 executable, and over 30% for the windows-amd64 executable.

I did some highly scientific ^^ benchmarks using time ./k0s on my machine, to compare startup times of the compressed and uncompressed versions of the executable. For me, compression added around 420 ms of startup latency.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Make this configurable via Make variables.

Signed-off-by: Tom Wieczorek <[email protected]>
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Feb 22, 2025
@ncopa
Copy link
Collaborator

ncopa commented Feb 24, 2025

How is memory usage affected? I assume that the memory usage will go up, but with how much?

@s3rj1k
Copy link

s3rj1k commented Mar 11, 2025

How is memory usage affected? I assume that the memory usage will go up, but with how much?

Not only memory but also CPU, as it will do decompression to memory on start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants