Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implimentation smell fix #104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implimentation smell fix #104

wants to merge 2 commits into from

Conversation

Shadow2121
Copy link

@Shadow2121 Shadow2121 commented Mar 20, 2025 •
edited
Loading

Modified validation conditions for more meaningful logs and error handling.

Type of change

  • code smell

How Has This Been Tested?

I ran existing test cases from PlaylistApiRetrofitTest

  • createPlaylistUsesCorrectValuesToCreateHttpCall
  • createPlaylistExecutesHttpCall
  • createPlaylistThrowsSpotifyActionFailedExceptionWhenError
  • createPlaylistThrowsHttpRequestFailedWhenHttpFails
  • createPlaylistThrowsIllegalArgumentExceptionWhenUserIdIsNull
  • createPlaylistThrowsIllegalArgumentExceptionWhenUserIdIsEmptry
  • createPlaylistThrowsIllegalArgumentExceptionWhenNameIsNullInsideRequestBody
  • createPlaylistThrowsIllegalArgumentExceptionWhenNameIsEmptyInsideRequestBody
  • uploadCoverImageToPlaylistUsesCorrectValuesToCreateHttpCall
  • uploadCoverImageToPlaylistExecutesHttpCall
  • uploadCoverImageToPlaylistThrowsSpotifyActionFailedExceptionWhenError
  • uploadCoverImageToPlaylistThrowsHttpRequestFailedWhenHttpFails
  • uploadCoverImageToPlaylistThrowsIllegalArgumentExceptionWhenPlaylistIdIsNull
  • uploadCoverImageToPlaylistThrowsIllegalArgumentExceptionWhenPlaylistIdEmpty
  • uploadCoverImageToPlaylistThrowsIllegalArgumentExceptionWhenBase64EncodedJpegImageIsNull
  • uploadCoverImageToPlaylistThrowsIllegalArgumentExceptionWhenBase64EncodedJpegImageIsEmpty

Checklist

  • My code follows the (style) guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shadow2121 @Shadow1069