Skip to content

Conversation

@dparring
Copy link

fixing up some signals. let me know if you want a different approach anywhere, especially around the added DBC and gear shift parsing

@github-actions
Copy link

github-actions bot commented Jul 25, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@dparring
Copy link
Author

Working off of the draft MLB PR, I think this will address the following open items (at least for Macan):

Solve issue with door-open signals
Solve issue with gearshift position signals

commaai#27586

@dparring dparring marked this pull request as draft January 17, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant