This repository was archived by the owner on Mar 23, 2024. It is now read-only.
Use config.assests.js_compressor setting for save original js compressor #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I set
config.assets.js_compressor
to compressor with some custom options likeUglifier.new(mangle: false)
The precompile task always get the error:
Sprockets::Error: unknown compressor: js_compressor
, there's because Sprocket::Environment will return:js_compressor
symbol when we want to getRails.application.assets.js_compressor
value if user set compressor to specific compressor object , please see https://github.com/sstephenson/sprockets/blob/master/lib/sprockets/compressing.rb#L60and when the task want to put
orignal_js_compressor
back toenv.js_compressor
, Sprocket can't find any compressor source name:js_compressor
and throw error.So it should be cache the
Rails.application.config.assets.js_compressor
(A real compressor object) tooriginal_js_compressor
notRails.application.assets.js_compressor
.ref #201