This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Fix for user config file not being propagated to run_config and build_config #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been hanging out there for a while now and it should be merged in. Either this or #198 I needed to setup an internal branch for my company since 0.9.5 to get things working. https://github.com/MediaFactual/requirejs-rails/tree/rjs-wrapshim-0.9.5 It would be great to get this merged in so that we can start using the official gem. |
|
Any news on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resulted in not working shims both for run time and build time
This fixes issue #197 (which was improperly closed beforehand)