Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartcrop takes a callback function as third arg #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sugoidesune
Copy link

I hope i did the typing right im new to typing

I hope i did the typing right im new to typing
@jwagner
Copy link
Owner

jwagner commented Feb 15, 2023

Hi Timar,

If I remember correctly the only reason why I kept the callback in is for backwards compatibility I think for new code it would be better to use the Promise returned.

Do you have a specific use case for which the callback works better than a promise?

@sugoidesune
Copy link
Author

No, it's just that it was part of an example and it's obviously annoying to not be able to run it.

@jwagner
Copy link
Owner

jwagner commented Feb 15, 2023

Do you have a link to the example in question? Would probably be best to just change the example to the recommended way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants