Skip to content

use absolute replacement paths in wheel builder #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matt-sm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use absolute replacement paths in wheel builder #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pycross/private/tools/wheel_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,8 @@ def get_default_build_env_vars(path_dirs: List[Path]) -> Dict[str, str]:
def replace_path_placeholders(
data: Dict[str, Union[str, List[str]]], placeholder: str, replacement: Path
) -> Dict[str, Any]:
replacement_str = str(replacement)
# Use absolute path for replacements so compiler/linker paths work from temp build dirs
replacement_str = str(replacement.resolve())
if replacement_str.endswith("/"):
replacement_str = replacement_str[:-1]
result = {}
Expand Down
Loading