GF Onboarding updates #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made to the file in prep for Google Fonts - added paint to .notdef character - removed kern classes from the tabular figures - added eleven-roman and twelve-roman, Eopen and Oopen - aligned nonbreakingspace to space - removed fsType restrictions - updated hhea to align to winMetrics - removed softhyphen - removed anchors from legacy marks and respaced them - added "top" anchor to /jdotless and updated ccmp to support it - removed _guide.han which was causing issues during build
…P to full blur. Default vertical metrics now set at 18% greater than the ideographic embox
Added vhea metric data into the font info Added "height" values to all glyphs that are not combining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I have been working on prepping Huninn for onboarding to GF and wanted to provide you with a PR of the changes I made, in case you'd like to merge them back upstream, or have any questions / comments.
Changelist:
Now the font will set properly in vertical scenarios!
On that last item, we recently have had a long discussion regarding how vertical metrics should be set for C/J font families, and finally decided to proceed with implementing a new approach on them. Please feel free to read that thread if you're interested in the background!
For Huninn, I have set the following metrics:
If you have a preference for these to be set differently, let's talk! I'm happy to discuss.