Remove redundant webview namespace from some types#121
Merged
just-be-dev merged 1 commit intomainfrom Feb 17, 2025
Merged
Conversation
just-be-dev
force-pushed
the
cleanup-rust-types
branch
from
bcdeb3d to
ea03854
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few of the generated types were prefixed with
WebviewlikeWebviewOptionsorWebviewRequest. This is both inconsistent with how other types are handled and causes weird duplication where in cases likeRequestthere's both aWebviewRequestandRequest(that was generated separately as a dependent type). This cleans that up in favor of a simpler naming scheme.