Skip to content

Allow scoped HTTP homelab connectors #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jusso-dev merged 1 commit into from
Jul 27, 2026
Merged

Allow scoped HTTP homelab connectors #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/database/src/bootstrap-connectors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { describe, expect, it } from "vitest";
import { environmentConnectorTestMode } from "./bootstrap-connectors.ts";

describe("environment connector bootstrap", () => {
it("permits scoped HTTP homelab connectors without weakening HTTPS connectors", () => {
expect(environmentConnectorTestMode("http://tawny.internal:5080")).toBe(
true,
);
expect(environmentConnectorTestMode("https://unifi.internal")).toBe(false);
});
});
6 changes: 5 additions & 1 deletion packages/database/src/bootstrap-connectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ type EnvironmentConnector = {
auth: ConnectorAuth;
};

export function environmentConnectorTestMode(baseUrl: string) {
return new URL(baseUrl).protocol === "http:";
}

function optionalEnvironmentConnector(input: {
product: "kelpie" | "tawny" | "unifi";
instanceId: string;
Expand All @@ -47,7 +51,7 @@ function optionalEnvironmentConnector(input: {
baseUrl: parsedUrl.toString(),
allowedHosts: [parsedUrl.hostname.toLowerCase()],
allowPrivateNetwork: true,
testMode: false,
testMode: environmentConnectorTestMode(parsedUrl.toString()),
...(input.tlsCaCertificateBase64?.trim()
? {
tlsCaCertificateBase64: input.tlsCaCertificateBase64.trim(),
Expand Down
Loading