Skip to content

fix(slack): accept workspace OAuth responses - #44

Merged
jusso-dev merged 1 commit into
mainfrom
fix/slack-oauth-null-enterprise
Jul 27, 2026
Merged

fix(slack): accept workspace OAuth responses#44
jusso-dev merged 1 commit into
mainfrom
fix/slack-oauth-null-enterprise

Conversation

@jusso-dev

@jusso-dev jusso-dev commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Improved Slack OAuth response handling when enterprise information is explicitly returned as null.
    • OAuth validation now accepts both absent and null enterprise details, preventing valid responses from being rejected.

@jusso-dev
jusso-dev merged commit 6690da4 into main Jul 27, 2026
2 of 5 checks passed
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dcb87455-4564-42a6-a033-67a57eb6e229

📥 Commits

Reviewing files that changed from the base of the PR and between ff45dfd and 90ce6a8.

📒 Files selected for processing (2)
  • packages/agent-harness/src/index.ts
  • packages/agent-harness/src/testing/fake-slack-server.ts

📝 Walkthrough

Walkthrough

The Slack OAuth response schema now accepts a null enterprise value, and the fake Slack server includes enterprise: null in successful OAuth responses.

Changes

Slack OAuth contract

Layer / File(s) Summary
Align OAuth schema and fixture
packages/agent-harness/src/index.ts, packages/agent-harness/src/testing/fake-slack-server.ts
The OAuth schema accepts a missing or null enterprise object, while successful fake OAuth responses explicitly return enterprise: null.

Estimated code review effort: 1 (Trivial) | ~5 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/slack-oauth-null-enterprise

Comment @coderabbitai help to get the list of available commands.

@jusso-dev
jusso-dev deleted the fix/slack-oauth-null-enterprise branch July 28, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant