-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate changelog as markdown #1281
Conversation
github-activity, used for other JupyterHub release processes, now outputs markdown. This PR moves the existing changelog to use markdown, and provides a more complete list of changes too. Ref jupyterhub#1280
for more information, see https://pre-commit.ci
Looks like most of the PR classification was lost in the regenerated changelog because I'm guessing they were grouped by hand instead of labeled. Maybe rst2myst would give a better starting point? |
This is what I use for converting the output of github-activity to RST:
Perhaps you can try reversing the sed commands? |
I don't even think we need to do that - the directives still exist and work, and rst2myst handles the syntax translation correctly. |
Thanks for working this @yuvipanda!!! I recall thinking I'd help drive the release effort in this repo once only to run into the "oh no... its a .rst changelog" and loosing momentum to get it done. I'd rather retain the changelog as it but with syntax conversion than to re-generate it and adopt github-activity going onwards, but I figure its also okay to re-generate things but I'd appreciate being able to overview changes to the changelogs content if that is done. I figure if a changelog is regenerated, we can have changes based on:
Btw for reference I wrote some notes on how I go about generating changelogs using github-activity in jupyterhub/team-compass#563, it includes the procedure of generating a changelog and then going to the PRs not labelled to label then, and then re-generating the changelog etc to get them categorized. |
no content change, only syntax
I pushed the rst2myst changelog.md here, which should be the simplest change and produce the same HTML. No manual edits. |
Yay, thank you @minrk |
github-activity, used for other JupyterHub release processes, now outputs markdown. This PR moves the existing changelog to use markdown, and provides a more complete list of changes too.
Ref #1280