Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring our release practices in line with rest of JupyterHub org #1280

Open
yuvipanda opened this issue Jun 5, 2023 · 5 comments
Open

Bring our release practices in line with rest of JupyterHub org #1280

yuvipanda opened this issue Jun 5, 2023 · 5 comments
Labels
maintenance Under the hood fixes and improvements

Comments

@yuvipanda
Copy link
Collaborator

JupyterHub now has a very well thought out release system (https://github.com/jupyterhub/jupyterhub/blob/main/RELEASE.md). repo2docker has some documentation, but it's a bit out of date. We should update our docs to match rest of JupyterHub.

yuvipanda added a commit to yuvipanda/repo2docker that referenced this issue Jun 5, 2023
github-activity, used for other JupyterHub release processes,
now outputs markdown. This PR moves the existing changelog
to use markdown, and provides a more complete list of
changes too.

Ref jupyterhub#1280
@consideRatio
Copy link
Member

consideRatio commented Jun 8, 2023

I looked at this to figure out details on the action points:

Input needed about...

release docs doesn't mention anything else like refreezing environments - should we do this before release and if so, linking to what docs on doing that?

@consideRatio consideRatio added the maintenance Under the hood fixes and improvements label Jun 8, 2023
@manics
Copy link
Member

manics commented Jun 8, 2023

I don't think refreezing environments should be part of the release process:

  • it increases the workload on the person managing the release
  • ideally we also want to test the refrozen environments by deploying to mybinder.org

I think it's fine to mention it as something to consider when planning a release though.

@consideRatio
Copy link
Member

ideally we also want to test the refrozen environments by deploying to mybinder.org

Are we using repo2docker main there?

@manics
Copy link
Member

manics commented Jun 8, 2023

Yes, e.g. jupyterhub/mybinder.org-deploy#2643

That's why we need versioneer (or some other auto versioning tool)- so we can have the git sha as part of the version for repo2docker installed from main, and for the container image built from main.

@minrk
Copy link
Member

minrk commented Jun 8, 2023

Agree that freezing should not be part of making a release, but is a good thing to highlight early in preparation for a release. Generally releases should be relatively long after freezes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Under the hood fixes and improvements
Projects
None yet
Development

No branches or pull requests

4 participants