Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the custom CSS handler is self.custom_css is set #7233

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 2, 2024

Investigate some ideas discussed in #7175

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Binder 👈 Launch a Binder on branch jtpio/notebook/custom-css

@jtpio jtpio added this to the 7.1 milestone Feb 2, 2024
@jtpio
Copy link
Member Author

jtpio commented Feb 2, 2024

Starting notebook with jupyter notebook --custom-css still seems to work with Notebook.

Testing with:

/* Modify Jupyter Styles */
#top-panel-wrapper,
#jp-top-bar {
  background-color: #aecad4 !important;
}

#menu-panel-wrapper,
#jp-MainMenu,
#menu-panel {
  background-color: #aecad4 !important;
}

.jp-NotebookPanel-toolbar {
  background-color: #aecad4 !important;
}
.lm-MenuBar-content {
  color: #02484d;
}

image

However it seems to be preventing lab to pick up the custom css (the top bar should be styled):

image

@jtpio
Copy link
Member Author

jtpio commented Feb 2, 2024

Although setting the lab trait explicitly seems to be doing the trick: jupyter notebook --custom-css --LabApp.custom_css=True:

image

@jtpio jtpio modified the milestones: 7.1.0, 7.1.x Feb 13, 2024
@jtpio jtpio modified the milestones: 7.1.x, 7.3.0 Oct 22, 2024
@jtpio jtpio modified the milestones: 7.3.0, 7.4.0 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant