patch server's sorted_extensions to prioritize nbclassic #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a test for this? When I was working on #49 I wasn't able to identify anything that didn't work, so it would be helpful to track that if it breaks in the future. |
Do you mind opening a new issue to track this integration test? |
Looks like we could then bump to https://github.com/jupyterlab/nbclassic/blob/979b2cfbd39f18e427a14673b85d2ee2b53f83c0/setup.py#L58 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #49. (@minrk)
nbclassic's nbserver server extension attempts to load classic server extensions (found in the old server config locations) with the new jupyter server.
It's critical that nbclassic be loaded before these extensions to ensure that nbclassic's
NotebookAppclass is initialized. because some of these server extensions might try to set traits on NotebookApp (that weren't ported+shimmed to ServerApp).An example: jupyter_nbexetensions_configurator sets
nbextensions_path, a trait in the classic NotebookApp. Nbclassic should pick up this trait, but can't if it's not initialized.This depends on jupyter-server/jupyter_server#522, so we should wait to merge until jupyter_server merges and releases.