Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mentioned Jupyter deskptop on "install" page #778

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hxrshxz
Copy link

@hxrshxz hxrshxz commented Jan 8, 2025

#737

Code changes

now the jupyter desktop is mentioned on the install page. talking about the try page we shouldn't be adding the jupyter desktop there the user won't be able to try the desktop version without installing it.

User-facing changes

Before
Before
After
after

Backwards-incompatible changes

None

kindly tell if anymore changes are needed

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we want to merge it right now as JupyterLab Desktop is not maintained as of now (last commit 6 months ago).

Install Jupyter Desktop with:

```bash
winget install jupyterlab
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Windows-only. Maybe we could also include snap instructions for Ubuntu?

@@ -38,6 +39,16 @@ To run the notebook:
jupyter notebook
```

## Jupyter Desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Jupyter Desktop
## JupyterLab Desktop

@@ -38,6 +39,16 @@ To run the notebook:
jupyter notebook
```

## Jupyter Desktop

Install Jupyter Desktop with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Install Jupyter Desktop with:
Install JupyterLab Desktop with:

winget install jupyterlab
```

**Note**: you can also install Jupyter Desktop by visiting [JupyterLab Desktop Releases](https://github.com/jupyterlab/jupyterlab-desktop/releases) page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note**: you can also install Jupyter Desktop by visiting [JupyterLab Desktop Releases](https://github.com/jupyterlab/jupyterlab-desktop/releases) page.
**Note**: you can also install JupyterLab Desktop by visiting [JupyterLab Desktop Releases](https://github.com/jupyterlab/jupyterlab-desktop/releases) page.

@@ -38,6 +39,16 @@ To run the notebook:
jupyter notebook
```

## Jupyter Desktop

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few words about JupyterLab Desktop could be useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants