Skip to content

Conversation

@krassowski
Copy link
Collaborator

Closes #333

@krassowski
Copy link
Collaborator Author

The documentation build failure is due to lib0 typing issues:

> @jupyter/[email protected] build /home/docs/checkouts/readthedocs.org/user_builds/jupyter-ydoc/checkouts/339/javascript
> tsc -b
node_modules/lib0/encoding.d.ts(6,11): error TS2315: Type 'Uint8Array' is not generic.
node_modules/lib0/encoding.d.ts(13,53): error TS2315: Type 'Uint8Array' is not generic.
node_modules/lib0/encoding.d.ts(146,21): error TS2315: Type 'Uint8Array' is not generic.
node_modules/lib0/encoding.d.ts(172,21): error TS2315: Type 'Uint8Array' is not generic.
node_modules/lib0/encoding.d.ts(208,21): error TS2315: Type 'Uint8Array' is not generic.
node_modules/lib0/encoding.d.ts(231,21): error TS2315: Type 'Uint8Array' is not generic.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @jupyter/[email protected] build: `tsc -b`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @jupyter/[email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/docs/.npm/_logs/2025-08-27T15_26_51_710Z-debug.log
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyter-ydoc/envs/339/lib/python3.8/site-packages/sphinx/cmd/build.py", line 285, in build_main
    app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyter-ydoc/envs/339/lib/python3.8/site-packages/sphinx/application.py", line 243, in __init__
    self.config.setup(self)
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyter-ydoc/checkouts/339/docs/source/conf.py", line 92, in setup
    check_call(cmd + ["run", "build"], cwd=str(js))
  File "/home/docs/.asdf/installs/python/3.8.20/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['npm', 'run', 'build']' returned non-zero exit status 1.
Exception occurred:
  File "/home/docs/.asdf/installs/python/3.8.20/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['npm', 'run', 'build']' returned non-zero exit status 1.

We need to upgrade typescript as in jupyterlab/extension-template#107

@krassowski krassowski changed the title Test against pycrdt-websocket v0.16.0 Test against pycrdt-websocket v0.16.0 & update dev dependencies Aug 28, 2025
@krassowski
Copy link
Collaborator Author

Any objections?

Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike.

@krassowski krassowski merged commit 13cbf43 into jupyter-server:main Nov 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Old pycrdt-websocket requirement

2 participants