-
Notifications
You must be signed in to change notification settings - Fork 101
🛫 Add documentation for Landing Pages #1864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 52e7f77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
genuinely excited for this feature. Thanks @agoose77 |
@rowanc1 note that if we use |
What about
please disregard this if I'm misunderstanding the problem! |
@agoose77 you can have blocks in blocks ... so I think this should be fine? |
Er @rowanc1 our schema states that we don't support that, which is why it's in my ➕ column for using blocks rather than directives 😅 What's the incentive for nested blocks? Shouldn't we use div for that? |
Ah, yeah, for a text-only/markup notebook that is true. We don't disallow blocks inside of markdown cells in an I don't think that a text-notebook actually puts in kind for the notebook content cells. Which I think is fine? I also think if you are overriding kind to be a landing-hero unit, I think that does make sense to be the override..?! |
I feel as though |
d512d3e
to
81f689d
Compare
Note
This PR depends upon jupyter-book/myst-theme#531
This PR modifies our block transform to pull
class
andkind
from.data
, and adds documentation for the landing-page feature.To try this PR out, build
mystmd
, and run it locally in the docs with e.g.env -C docs -- npx myst start --headless
, then run the book-theme from themyst-theme
PR.