Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎆 Add static figure placeholder for images #1744

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fwkoch
Copy link
Collaborator

@fwkoch fwkoch commented Jan 9, 2025

This is the subset of the changes from #1701 which focuses on the static image field, an alternative to placeholder that will only be used in static exports, e.g. PDF. There is a little more discussion in that previous PR.

Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 0cbc068

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
myst-directives Patch
myst-transforms Patch
myst-cli Patch
myst-parser Patch
myst-roles Patch
myst-to-html Patch
mystmd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rowanc1 rowanc1 added the blocked Waiting for another task to be compled label Jan 9, 2025
@agoose77
Copy link
Contributor

agoose77 commented Jan 10, 2025

@fwkoch I spoke with @stevejpurves about this today in #1157 (comment).

For this PR, the TL;DR is that it might be better to not add a new static field, and instead add an option that myst-theme should respect for ignoring placeholders (e.g. web-use-placeholder: false). Would you be against that? I can support the theme PR.

@rowanc1
Copy link
Member

rowanc1 commented Jan 10, 2025

@fwkoch and I were talking about this in the context of another feature: only and I think that is both more flexible and hits this use case.

Let's explore that (which is necessary for supporting some of the books we are working on), and see if that replaces the need here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting for another task to be compled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants