Compile module descriptors using regular compileJava task
#4523
+106
−243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
force-pushed
the
marc/module-descriptor-compilation-cleanup
branch
from
0a3778e to
1a50e16
Compare
marcphilipp
commented
May 9, 2025
| @@ -21,6 +22,11 @@ dependencies { | |||
| osgiVerification(projects.junitPlatformLauncher) | |||
| } | |||
|
|
|||
| extraJavaModuleInfo { | |||
| automaticModule(libs.univocity.parsers, "univocity.parsers") | |||
There was a problem hiding this comment.
💬 This is used to add an Automatic-Module-Name manifest to the JAR so Gradle will put it on the module path.
marcphilipp
commented
May 9, 2025
Comment on lines
+57
to
+58
| addStringOption("-add-modules", "univocity.parsers") | ||
| addStringOption("-add-reads", "${javaModuleName}=univocity.parsers") |
There was a problem hiding this comment.
💬 Javadoc for individual subprojects now also uses the module path instead of the classpath and hence needs these options as well.
marcphilipp
commented
May 9, 2025
marcphilipp
commented
May 9, 2025
junit-jupiter-migrationsupport/junit-jupiter-migrationsupport.gradle.kts
Outdated
Show resolved
Hide resolved
marcphilipp
commented
May 9, 2025
| " \"module\": \"junit-jupiter-engine\",", // | ||
| " \"version\": {", // | ||
| ">> VERSION >>", // | ||
| " }", // |
There was a problem hiding this comment.
💬 Only the order has changed here
marcphilipp
force-pushed
the
marc/module-descriptor-compilation-cleanup
branch
from
881f2eb to
120e8ab
Compare
marcphilipp
force-pushed
the
marc/module-descriptor-compilation-cleanup
branch
from
f0a3da4 to
493a827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR gets rid of the extra
JavaCompiletasks calledcompileModulethat were used to compile the module descriptors, moves them tosrc/main/java, and uses the regularcompileJavatask to compile them alongside the regular Java sources.Definition of Done
@APIannotations