Introduce zero invocations in test templates and parameterized tests #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need this feature a lot! Is there a forecast for when it will be ready? |
marcphilipp
requested changes
Sep 23, 2024
...api/src/main/java/org/junit/jupiter/api/extension/TestTemplateInvocationContextProvider.java
Outdated
Show resolved
Hide resolved
...ter-engine/src/main/java/org/junit/jupiter/engine/descriptor/TestTemplateTestDescriptor.java
Outdated
Show resolved
Hide resolved
...api/src/main/java/org/junit/jupiter/api/extension/TestTemplateInvocationContextProvider.java
Outdated
Show resolved
Hide resolved
junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTestExtension.java
Outdated
Show resolved
Hide resolved
...api/src/main/java/org/junit/jupiter/api/extension/TestTemplateInvocationContextProvider.java
Outdated
Show resolved
Hide resolved
nskvortsov
added a commit
to nskvortsov/junit5
that referenced
this pull request
Oct 2, 2024
Updated `since` tag values, improved naming.
nskvortsov
added a commit
to nskvortsov/junit5
that referenced
this pull request
Oct 2, 2024
Updated `since` tag values, improved naming.
nskvortsov
added a commit
to nskvortsov/junit5
that referenced
this pull request
Oct 13, 2024
Make error messaging even more precise. Print out the provider class that did not return any template invocation contexts.
|
Let me know if you are ok with the latest change, I will do the rebase. |
marcphilipp
approved these changes
Oct 15, 2024
Thanks for making the changes. I'll take it from here! |
Add a flag to ParameterizedTest to control arguments requirement. This allows users to explicitly opt out from validation of arguments set count and silently skip a test if no arguments are provided In general, support TestTemplateInvocationContextProvider returning zero invocation contexts. Such providers must override new interface method to indicate that the framework should expect "no context returned" Resolves junit-team#1477
|
@nskvortsov Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to ParameterizedTest to control arguments requirement. This allows users to explicitly opt out from validation of arguments set count and silently skip a test if no arguments are provided
In general, support TestTemplateInvocationContextProvider returning zero invocation contexts. Such providers must override new interface method to indicate that the framework should expect "no context returned"
Resolves #1477
Overview
Implemented the team decision described in this comment
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations