Add `Locale` conversion format configuration property #3410

scordio · 2023-07-31T10:04:11Z

Overview

Fixes #3141.

I hereby agree to the terms of the JUnit Contributor License Agreement.

There are no TODOs left in the code
Method preconditions are checked and documented in the method's Javadoc
Coding conventions (e.g. for logging) have been followed
Change is covered by automated tests including corner cases, errors, and exception handling
Public API has Javadoc and @API annotations
Change is documented in the User Guide and Release Notes

junit-jupiter-engine/junit-jupiter-engine.gradle.kts

scordio · 2023-07-31T10:10:12Z

...-jupiter-params/src/main/java/org/junit/jupiter/params/converter/LocaleConversionFormat.java

+ *
+ * @since 5.11
+ */
+@API(status = INTERNAL, since = "5.11")


Is it correct to mark this as an internal API as the users are supposed to set these values in the config property only and not rely on the enum?

scordio · 2023-11-09T06:58:49Z

Waiting for #3507 to be finalized before moving forward.

marcphilipp · 2024-10-16T07:54:45Z

@scordio Are you still interested in continuing with this PR?

scordio · 2024-10-16T08:01:57Z

Yes! This has fallen under my radar... thanks for the reminder 🙂

I'll rebase it and catch up with the missing parts in the upcoming weeks.

scordio commented Jul 31, 2023

View reviewed changes

junit-jupiter-engine/junit-jupiter-engine.gradle.kts Show resolved Hide resolved

scordio commented Jul 31, 2023

View reviewed changes

scordio force-pushed the locale_conversion_config_property branch from abfc72b to 95da5f8 Compare July 31, 2023 10:13

scordio changed the title ~~Add locale conversion format configuration property~~ Add Locale conversion format configuration property Jul 31, 2023

scordio added 2 commits August 14, 2023 23:20

Add Locale conversion format configuration property

28a07c9

Fix dumb mistake

f833690

scordio force-pushed the locale_conversion_config_property branch from 95da5f8 to f833690 Compare August 14, 2023 21:50