Remove ConsoleLauncher configuration in Ant starter (#98) #114
Conversation
sbrannen
changed the title
junit5-jupiter-starter-ant/build.sh
Outdated
| (cd "${ant_folder}/lib" && curl --remote-name "http://central.maven.org/maven2/org/junit/platform/junit-platform-commons/${junit_platform_version}/junit-platform-commons-${junit_platform_version}.jar") | ||
| (cd "${ant_folder}/lib" && curl --remote-name "http://central.maven.org/maven2/org/junit/platform/junit-platform-engine/${junit_platform_version}/junit-platform-engine-${junit_platform_version}.jar") | ||
| (cd "${ant_folder}/lib" && curl --remote-name "http://central.maven.org/maven2/org/junit/platform/junit-platform-launcher/${junit_platform_version}/junit-platform-launcher-${junit_platform_version}.jar") | ||
| (cd "${ant_folder}/lib" && curl --remote-name "http://central.maven.org/maven2/org/junit/jupiter/junit-jupiter-api/${junit_jupiter_version}/junit-jupiter-api-${junit_jupiter_version}.jar") | ||
| (cd "${ant_folder}/lib" && curl --remote-name "http://central.maven.org/maven2/org/junit/jupiter/junit-jupiter-engine/${junit_jupiter_version}/junit-jupiter-engine-${junit_jupiter_version}.jar") | ||
| (cd "${ant_folder}/lib" && curl --remote-name "http://central.maven.org/maven2/org/junit/jupiter/junit-jupiter-params/${junit_jupiter_version}/junit-jupiter-params-${junit_jupiter_version}.jar") | ||
| (cd "${ant_folder}/lib" && curl --remote-name "http://central.maven.org/maven2/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar") | ||
| (cd "${ant_folder}/lib" && curl --remote-name "http://central.maven.org/maven2/org/apiguardian/apiguardian-api/1.1.0/apiguardian-api-1.1.0.jar") |
There was a problem hiding this comment.
Wouldn't it be easier to use Apache Ivy to retrieve the necessary dependencies instead of handling that manually with curl?
There was a problem hiding this comment.
How about supporting Ivy when supporting Ant-wrapper at #66 ?
There was a problem hiding this comment.
Why not keeping junit-platform-console-standalone JAR here? Does it no longer work with the <junitlauncher> task?
There was a problem hiding this comment.
How about supporting Ivy when supporting Ant-wrapper at #66 ?
Does the Ant-wrapper make it somehow easier to use Ivy?
There was a problem hiding this comment.
Why not keeping
junit-platform-console-standaloneJAR here? Does it no longer work with the<junitlauncher>task?
Ant allows testing to be launched, so junit-platform-console-standalone is not required.
https://ant.apache.org/manual/Tasks/junitlauncher.html
There was a problem hiding this comment.
How about supporting Ivy when supporting Ant-wrapper at #66 ?
Does the Ant-wrapper make it somehow easier to use Ivy?
I don't know much the Ant-wrapper. Is it better to use ivy directly?
There was a problem hiding this comment.
In my opinion, it's always better to use Ant with Ivy, since Ivy provides dependency management similar to that provided by Maven or Gradle.
From the documentation for the Ant-wrapper, it appears that that's easier to set up if you're already using Ivy.
So maybe we should actually take the following steps.
- Use Ivy in the Ant examples.
- Use the Ant-wrapper in the Ant examples.
- Use the
junitlaunchertask in the Ant examples.
Thoughts?
There was a problem hiding this comment.
I see, sounds good! but what does mean No.3? I already use this one fb685f4#diff-72ebd09ba035959b381f450ac03a68efR37
There was a problem hiding this comment.
I meant that we should ideally follow those steps.
But... if we mix up the order a bit and still arrive at the same outcome, that works, too. 😉
sbrannen
dismissed
their stale review
Let's push the use of Ivy to a separate issue
|
With two approvals and since I think his requested changes have been resolved, I think we can overrule @sbrannen this once. |
Overview
Fixes #98
Fixes #115
I hereby agree to the terms of the JUnit Contributor License Agreement.