Fixed: Fix the issue where the common Drawer Title is displayed in English #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaiJiangJie
reviewed
Feb 25, 2025
| } | ||
| title = toSentenceCase(action) + this.$t('WordSep') + toLowerCaseExcludeAbbr(title) | ||
| title = dispatchAction + this.$t('WordSep') + toLowerCaseExcludeAbbr(title) | ||
| return title | ||
| }, | ||
| getDefaultDrawer(action) { |
There was a problem hiding this comment.
The code appears to be formatted correctly, but some changes have been made in the getDefaultTitle method of the component. These include:
- Adding parentheses before and after the call expressions.
- Replacing "export" with
returnkeyword.
As far as potential issues or optimization suggestions go, I would need more specific details about what needs to be refined. It's generally best to analyze the overall structure and usage examples provided in order to make meaningful improvements. However, there might not necessarily be any significant structural modifications needed based on these small adjustments alone.
|
ZhaoJiSen
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Fix the issue where the common Drawer Title is displayed in English