Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Fix the adaptation issue of the Dashboard on the account password change page. #4669

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Feb 24, 2025

Fixed: Fix the adaptation issue of the Dashboard on the account password change page.

@fit2bot fit2bot requested a review from a team February 24, 2025 08:20
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
}
}
</style>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no known issue present, but here are some suggestions:

  • The usage of export statement with curly braces in JavaScript seems to be outdated. Instead, try using an asterisk or the colon (:) method like this: export default.
    export default function() { ... };
  * Style components must use 'scoped' CSS rules instead of inline styles. Use ':v-deep'. Consider wrapping them in ::after pseudo element for consistency.
  * In SCSS files, it's best practice to write only one level deep. Try writing more than one line on each new-line so that they can be easily grouped and expanded without needing additional spaces.

In conclusion, you have provided almost complete syntax guidelines which need adjustments to align better and adhere to modern practices.

text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
}
}
</style>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the provided code snippet, there does not appear to be any significant difference that would need reviewing or fixing. The code is written in Angular (v2) and follows good practices for CSS classes like flex and width, making the card responsive while maintaining readability.

However, if you're looking for stylistic improvements or specific design requirements, please specify those details so I can assist more accurately.


.risk-summary {
margin-top: 1.25rem;
}
}
</style>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no significant differences between the two files.

@ZhaoJiSen ZhaoJiSen merged commit e8e3ca1 into dev Feb 24, 2025
3 of 4 checks passed
@ZhaoJiSen ZhaoJiSen deleted the pr@dev@fixed_account_secret_dashboard branch February 24, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants