-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: agw page #1757
feat: agw page #1757
Conversation
Staging Release
Staging Release
Staging Release
chore: show AGW
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Test results (4/4)Details
|
Test results (2/4)Details
Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color |
Test results (3/4)Details
|
Test results (1/4)Details
Failed testschromium › connectWallet.spec.ts › Connect Metamask with Jumper app and open /profile page › should connect wallet to Jumper Skipped testschromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission |
fromChain: | ||
(theme.lightConfig || theme.darkConfig)?.config?.fromChain ?? undefined, | ||
toChain: | ||
(theme.lightConfig || theme.darkConfig)?.config?.toChain ?? undefined, | ||
toToken: | ||
(theme.lightConfig || theme.darkConfig)?.config?.toToken ?? undefined, | ||
fromToken: | ||
(theme.lightConfig || theme.darkConfig)?.config?.fromToken ?? undefined, | ||
variant: | ||
(theme.lightConfig || theme.darkConfig)?.config?.variant ?? undefined, | ||
chains: | ||
(theme.lightConfig || theme.darkConfig)?.config?.chains ?? undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important piece to format the configTheme.
fromChain: | ||
configTheme.fromChain ?? (fromChain || widgetCache.fromChainId), | ||
fromToken: configTheme.fromToken ?? (fromToken || widgetCache.fromToken), | ||
toChain: configTheme.toChain ?? toChain, | ||
toToken: configTheme.toToken ?? toToken, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before, I had duplication which is not clean and DRY -> Using formParameters to specify fromChain, fromToken, toChain, toToken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something odd about useWidgetConfig -> It does not seem to be used at all but to keep consistency I added changes in both places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaning story needs to be handled straight after this one
No description provided.