Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agw page #1757

Merged
merged 49 commits into from
Feb 13, 2025
Merged

feat: agw page #1757

merged 49 commits into from
Feb 13, 2025

Conversation

dennyscode
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jumper-exchange ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 10:32am

Copy link

github-actions bot commented Feb 12, 2025

Test results (4/4)

passed  5 passed

Details

stats  5 tests across 2 suites
duration  28.2 seconds
commit  2592740

Copy link

github-actions bot commented Feb 12, 2025

Test results (2/4)

passed  4 passed
skipped  1 skipped

Details

stats  5 tests across 1 suite
duration  14.9 seconds
commit  2592740

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open quests mission page and switch background color

Copy link

github-actions bot commented Feb 12, 2025

Test results (3/4)

passed  5 passed

Details

stats  5 tests across 2 suites
duration  27.6 seconds
commit  2592740

Copy link

github-actions bot commented Feb 12, 2025

Test results (1/4)

failed  2 failed
passed  3 passed
skipped  1 skipped

Details

stats  6 tests across 2 suites
duration  8 minutes, 27 seconds
commit  2592740

Failed tests

chromium › connectWallet.spec.ts › Connect Metamask with Jumper app and open /profile page › should connect wallet to Jumper
chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to open menu and click away to close it

Skipped tests

chromium › e2e.spec.ts › Jumper full e2e flow › Should be able to navigate to profile and open first Mission

Comment on lines +92 to +103
fromChain:
(theme.lightConfig || theme.darkConfig)?.config?.fromChain ?? undefined,
toChain:
(theme.lightConfig || theme.darkConfig)?.config?.toChain ?? undefined,
toToken:
(theme.lightConfig || theme.darkConfig)?.config?.toToken ?? undefined,
fromToken:
(theme.lightConfig || theme.darkConfig)?.config?.fromToken ?? undefined,
variant:
(theme.lightConfig || theme.darkConfig)?.config?.variant ?? undefined,
chains:
(theme.lightConfig || theme.darkConfig)?.config?.chains ?? undefined,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important piece to format the configTheme.

Comment on lines +114 to +118
fromChain:
configTheme.fromChain ?? (fromChain || widgetCache.fromChainId),
fromToken: configTheme.fromToken ?? (fromToken || widgetCache.fromToken),
toChain: configTheme.toChain ?? toChain,
toToken: configTheme.toToken ?? toToken,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before, I had duplication which is not clean and DRY -> Using formParameters to specify fromChain, fromToken, toChain, toToken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something odd about useWidgetConfig -> It does not seem to be used at all but to keep consistency I added changes in both places.

Copy link
Contributor

@oktapodia oktapodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaning story needs to be handled straight after this one

@tcheee tcheee merged commit 730db33 into develop Feb 13, 2025
5 of 6 checks passed
@tcheee tcheee deleted the agw-page-redo branch February 13, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants