Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix: Add correct parameters for set_attribute in installation.md #3957

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

Prasanthi-Peram
Copy link
Contributor

Reference : https://github.com/jump-dev/JuMP.jl/blob/master/src/optimizer_interface.jl

From the implementation of the
set_optimizer_attribute( model::Union{GenericModel,MOI.OptimizerWithAttributes}, attr::Union{AbstractString,MOI.AbstractOptimizerAttribute}, value) method;

The function expects three parameters however Installation Guide uses a (model,key value pair) in the solvers' section which throws a Method Error at runtime. This fix would solve the issue.

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops! That's an embarrassing mistake on my part.

Thanks for the PR. I've tweaked it slightly to make the code block a jldoctest. This will run the code when we build the documentation to check that it runs without error.

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (812a073) to head (7048553).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3957   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         6054      6054           
=========================================
  Hits          6054      6054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow odow merged commit 02fabbf into jump-dev:master Mar 10, 2025
9 of 10 checks passed
@odow
Copy link
Member

odow commented Mar 10, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants