-
Notifications
You must be signed in to change notification settings - Fork 922
chore(docker-compose): Add profiles in docker-compose.yml and documen… #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to d5ef28a in 1 minute and 8 seconds. Click for details.
- Reviewed
39
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
4
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docker-compose.yml:7
- Draft comment:
Verify that the 'include' syntax with 'path' and 'profiles' is supported in your Docker Compose version. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
2. docker-compose.yml:12
- Draft comment:
Ensure the scheduler service is intended to run only under the 'self-hosted-temporal' profile. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
3. documentation/advanced/localsetup.mdx:65
- Draft comment:
Updated multi-tenant command now includes the new profiles; confirm its consistency with docker-compose.yml. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
4. documentation/advanced/localsetup.mdx:69
- Draft comment:
Typo: The sentence "that act as an API KEY" should probably use a verb agreement correction: "that acts as an API key". - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_GEfheQNJ9JNnMHGS
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
…e to include additional profiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed edef69d in 37 seconds. Click for details.
- Reviewed
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. documentation/advanced/localsetup.mdx:56
- Draft comment:
The updated command now includes '--profile self-hosted-temporal' and '--profile local-db' to enable the new services. Ensure this aligns with the docker-compose.yml profiles. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_oO7N6a1odhocD9Kv
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
User description
Close #1323
Added two Docker profiles:
local-db
to includememory-store
serviceself-hosted-temporal
to includescheduler
serviceUsing these profiles you can exclude these services instead of editing the docker compose file.
Also updated the Local Setup section in the documentation to use the new profiles.
PR Type
enhancement, documentation
Description
Added Docker Compose profiles for
memory-store
andscheduler
services.Updated documentation to explain new profile usage.
Enabled configurable inclusion of services via profiles.
Changes walkthrough 📝
docker-compose.yml
Add profiles for memory-store and scheduler services
docker-compose.yml
profiles
keys tomemory-store
andscheduler
service includes.local-db
andself-hosted-temporal
profiles.
localsetup.mdx
Document usage of new Docker Compose profiles
documentation/advanced/localsetup.mdx
Important
Add Docker Compose profiles for
memory-store
andscheduler
services and update documentation for profile usage.local-db
andself-hosted-temporal
indocker-compose.yml
formemory-store
andscheduler
services.localsetup.mdx
to document new profile usage in setup instructions.This description was created by
for edef69d. You can customize this summary. It will automatically update as commits are pushed.