fix(analytics): record real client IP behind nginx ingress#81
Merged
Conversation
Web Analytics recorded cluster-internal ingress-nginx pod IPs because ANALYTICS_TRUSTED_PROXIES was never set, so extractClientIp() ignored X-Forwarded-For and used the socket peer. - Set NUXT_ANALYTICS_TRUSTED_PROXIES (private ranges) in the k8s base configmap so the app honors X-Forwarded-For from the in-cluster proxy. NUXT_-prefixed so it overrides runtimeConfig at runtime. - getAnalyticsConfig() now coerces trustedProxies from a comma-string as well as an array, so the runtime NUXT_ override (which arrives as a string) is not silently dropped to []. - Add regression test for the coercion. - Document the NUXT_ prefix requirement and ingress externalTrafficPolicy caveat in the production checklist and .env.example. https://claude.ai/code/session_01VovHZ6DxypcGAFDmpRzKH3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web Analytics recorded cluster-internal ingress-nginx pod IPs because
ANALYTICS_TRUSTED_PROXIES was never set, so extractClientIp() ignored
X-Forwarded-For and used the socket peer.
configmap so the app honors X-Forwarded-For from the in-cluster proxy.
NUXT_-prefixed so it overrides runtimeConfig at runtime.
well as an array, so the runtime NUXT_ override (which arrives as a
string) is not silently dropped to [].
caveat in the production checklist and .env.example.
https://claude.ai/code/session_01VovHZ6DxypcGAFDmpRzKH3