Fix #946: Add standard iterator traits to CharPointer_UTF8 for compat… #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TF8 for compatibility with std algorithms - Added value_type, pointer, reference, iterator_category, and difference_type typedefs - Enables CharPointer_UTF8 to work with standard library algorithms like std::all_of - Uses input_iterator_tag as the most appropriate category for UTF-8 character iteration - Maintains full backward compatibility with existing code - Tested with both GCC and Clang compilers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #946: Add standard iterator traits to CharPointer_UTF8 for compatibility with std algorithms
Thank you for submitting a pull request.
Please make sure you have read and followed our contribution guidelines (.github/contributing.md in this repository). Your pull request will not be accepted if you have not followed the instructions.
As a side note, I think that the policy described in CONTRIBUTING.md—where PRs are not merged directly into public branches but reproduced in the private repository—could potentially undervalue contributors by not preserving their commit history, authorship, or direct recognition in the public repo. While I understand the need for controlled integration in a hybrid open-source/commercial project, this approach might feel a bit unethical or discouraging to community members who invest time in fixes, as it limits visibility of their contributions (e.g., no GitHub credit for merges). Perhaps considering ways to attribute reproduced changes publicly, like mentioning contributors in changelogs or commit messages, could help maintain motivation and fairness. I'd be interested in the team's thoughts on this if possible!