Fix range input for hardware temperature and humidity offset for ZSE11 and ZSE44#42
Open
memorsolutions wants to merge 1 commit intojtp10181:beta-sensorsfrom
Open
Fix range input for hardware temperature and humidity offset for ZSE11 and ZSE44#42memorsolutions wants to merge 1 commit intojtp10181:beta-sensorsfrom
memorsolutions wants to merge 1 commit intojtp10181:beta-sensorsfrom
Conversation
Owner
|
This used to work correctly as-is. It probably broke with the updated UI a few versions back. Looks like a good fix. I need to do some major updates soon, I will check it out and merge it when get some time to focus on these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address #41.
The fix involves adding a new, optional value to the
paramsMaparray calleddataType. It supports specifying an alternate data type, such as"decimal"so that the code in theconfigParams.eachclosure withinmetadata.preferencesuses thedataTypemember in theinputfunction if provided.